Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: logrotate https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226104 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-08 16:25 EST ------- >> No downloadable source. Please give the full URL in the Source tag. > There isn't any URL you can download sources from. RH is upstream for logrotate. Agreed. >> Use DESTDIR instead of PREFIX in %install > I can't use DESTDIR, since there isn't standart Makefile in logrotate. Ok. >> Is it necessary to create the empty logrotate.status? > bz #55809 Ok, I'm not sure this is a bug, but is doesn't do any harm either. One thing left: you haven't converted all paths to macro's There's /etc in %install, replace that with %{_sysconfdir} Replace /var with %{_localstatedir} Thanks, Ruben -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review