https://bugzilla.redhat.com/show_bug.cgi?id=842679 Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- There is only one thing I'm not sure of here: whether it is better to depend on /usr/bin/rspec or %{_bindir}. I guess the second alternative is the right one, because it doesn't hardcode the path. So please fix it before import. Otherwise this package looks good, so it is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review