https://bugzilla.redhat.com/show_bug.cgi?id=842328 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * More specific license - Although it seems that the license field is correct, could you please elaborate a bit more what license is for what library? * Smoke test failed? - I did just small smoketest and it failed. I believe that it depends on Rails application configuration, but anyway, could you please doublecheck? $ irb reqirb(main):001:0> require 'jquery-rails' NameError: uninitialized constant Rails from /usr/share/gems/gems/jquery-rails-2.0.2/lib/jquery/rails/engine.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require' from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require' from /usr/share/gems/gems/jquery-rails-2.0.2/lib/jquery/rails.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require' from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require' from /usr/share/gems/gems/jquery-rails-2.0.2/lib/jquery-rails.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/custom_require.rb:60:in `require' from /usr/share/rubygems/rubygems/custom_require.rb:60:in `rescue in require' from /usr/share/rubygems/rubygems/custom_require.rb:35:in `require' from (irb):1 from /usr/bin/irb:12:in `<main>' Otherwise I see no issue => APPROVED. But please, make sure that you understand the above mentioned error and better describe the licenses before import. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review