[Bug 842379] Review Request: mcollective-qpid-plugin - Plugin to enable m-collective communication over amqp 1.0 enabled broker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=842379

Michael Scherer <misc@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc@xxxxxxxx

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> ---
Hi,

as I assume this is not gonna be backported to EPEL 5, I think you can and
should clean :

- BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
( no longer needed )


%clean
rm -rf %{buildroot}

Done by default on Fedora, maybe needed for EPEL 6 ( not sure ).


%defattr(-,root,root,-)

( set by default, so can be removed )


rm -rf %{buildroot}   
( after %install, and also already done by default )


There is also no license bundled with the tarball, and policy requires to nag
upstream about adding it :) . There is also no license in the ruby file, so
that's problematic. Can you ask upstream to add both ( a copy of the license,
and a comment in the ruby file with copyright, etc ) ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]