[Bug 781823] Review Request: easyplay - An easy to use categories- and playlists-based music player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=781823

--- Comment #7 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4324212



More issues:

Drop python3-libs from Requires. It is needed by python3. The same for python3
and phonon, which are needed by python3-PyQt4 anyway.

URL: must contain the whole URL, including the http:// prefix.

According to README, the license has to be GPLv3+. 

Because nothing is to build, you might drop python-devel from BR. The package
installs only files directly and doesn't use setup.py, which would need the
Makefile from python3-devel.

Remove the %defattr line from %files, unless you want to provide your package
for EPEL <6.

%attr(755,root,root) %{_bindir}/%{name}
The %attr prefix is probably unneeded, because you've installed it with
"install -m 755 -d %{buildroot}/%{_bindir}".



Some things got from rpmlint:

easyplay.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.


easyplay.noarch: E: non-executable-script
/usr/lib/python3.2/site-packages/easyplay/MainWindow.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

I've got the same error message for all the files in
/usr/lib/python3.2/site-packages/easyplay/. Don't know what this actually
means, but I assume there are special guidelines therefore. Perhaps it is
sufficient to install all the files with an executable bit...? But obviously
other packages don't set this bit for the files therein.


easyplay.src: E: specfile-error sh: line 0: fg: no job control
This error occurred when rpmlint used rpm to query the specfile.  The error is
output by rpm and the message should contain more information.

Don't know what the problem is. I cannot see any peculiarities in the shell
script...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]