[Bug 813842] Review Request: glfw , A cross-platform multimedia library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=813842

--- Comment #11 from MERCIER Jonathan <bioinfornatics@xxxxxxxxx> ---

Really big thanks Paul for your work 


Below is an artefact to mine glfw3.spec sorry
Requires:       GLFW3-devel

>> %build
>> make %{?_smp_mflags} x11 
>>
>> ...
>>
>> %install
>> make %{?_smp_mflags} x11-dist-install PREFIX=/usr LIBDIR=%{_lib}
>> DESTDIR=%{buildroot} CFLAGS="$RPM_OPT_FLAGS"
>
> That asks for a closer look. Why do you add CFLAGS for "install" but not "build". Nothing ought to be compiled anymore in the %install section.

yes i agree it was an error, fixed



>> Requires:       %{name} =  %{version}-%{release}

> https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Fixed

> I would just remove the static subpackage completely and only provide the dynamic libs
Static subpackage removed

Curently i got a littlke build problem
../internal.h:92:22: fatal error: platform.h: No such file or directory


I looking to fix it

just to see what is new:
- http://bioinfornatics.fedorapeople.org/glfw-2.7.6-2.fc17.src.rpm
- http://bioinfornatics.fedorapeople.org/glfw-2.7.6-soname-cflags.patch
- http://bioinfornatics.fedorapeople.org/glfw.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]