[Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=842124

Michael Scherer <misc@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc@xxxxxxxx

--- Comment #2 from Michael Scherer <misc@xxxxxxxx> ---
Hi,

a few notes :

- BuildRequires:    libXfixes
BuildRequires:    libXfixes-devel

this seems redundant ( ie, the -devel should pull the regular library )

- No need to clean in %install
%install
rm -rf $RPM_BUILD_ROOT

that's already done by rpm since a long time

- unowned directory

I am npot sure, but it seems that the direcotry 
%{_libdir}/qt4/plugins/menubar/libappmenu
is unowned. This should be fixed :
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]