Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gimmie - Gnome panel revisited https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227717 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-02-08 13:07 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files match upstream. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is LGPL matched with COPYING file entry. + %doc is right (NEWS can be dropped from this field). + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + post ans postun is correctly set. + python_sitelib present. + Macro use appears rather consistent. (just use %{name}insted of gimmie + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. ------- I can approved it cause i'm not a sponsor. You should think about adding a desktop entry for this app. ------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review