https://bugzilla.redhat.com/show_bug.cgi?id=785450 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady --- Comment #4 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml [MUST] Change Requires: php-pear(pear.horde.org/Horde_Util) <= 2.0.0 to Requires: php-pear(pear.horde.org/Horde_Util) < 2.0.0 to satisfy package.xml [OPTIONAL] For readability, you may want to group your Build* and Requires* [OPTIONAL] I'm not sure what the exact Fedora packaging guidelines are for this, but I prefer to be very verbose and would list both the min and max requirements instead of just max (even though you know you don't have < 1.0.0 in Fedora): Requires: php-pear(pear.horde.org/PACKAGE) >= 1.0.0 Requires: php-pear(pear.horde.org/PACKAGE) < 2.0.0 [OPTIONAL] You may want to consider adding requires for the following optional dependencies (from package.xml): * php-pear(pear.horde.org/Horde_Db) * php-pear(pear.horde.org/Horde_Log) * php-pear(pear.horde.org/Horde_Memcache) -- be careful with this one as I don't know whether this would cause issues in certain environments like APC does (which is also an optional requirement of this package) [OPTIONAL] phpci: You may want to consider adding the following requires: * php-date * php-hash * php-spl * php-pecl(LZF) >= 1.5.2 --- NOTE: package.xml lists the hash extension as required, but it is a virtual package of php-common (as php-hash) so it would automatically be installed. You may want to consider adding the requirement to be thorough and prevent any future issue of there is PHP package changes. --- NOTE: You may want to have upstream add the additional optional extensions (LZF is already listed in package.xml as optional) [OPTIONAL] You may want to s/pear.horde.org/%{pear_channel}/ and then add "%global pear_channel pear.horde.org" -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review