https://bugzilla.redhat.com/show_bug.cgi?id=785447 --- Comment #5 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml [SHOULD] lib/Horde/Auth/Sql.php includes "$now = new Horde_Date(time());". Please verify Horde_date is not a dependency. [SHOULD] %check is present and all tests pass [OPTIONAL] For readability, you may want to group your Build* and Requires* [OPTIONAL] I'm not sure what the exact Fedora packaging guidelines are for this, but I prefer to be very verbose and would list both the min and max requirements instead of just max (even though you know you don't have < 1.0.0 in Fedora): Requires: php-pear(pear.horde.org/PACKAGE) >= 1.0.0 Requires: php-pear(pear.horde.org/PACKAGE) < 2.0.0 [OPTIONAL] You may want to consider adding requires for the following optional dependencies (from package.xml): * php-pear(pear.horde.org/Horde_Db) * php-pear(pear.horde.org/Horde_History) * php-pear(pear.horde.org/Horde_Lock) * php-pear(pear.horde.org/Horde_Imap_Client) * php-pear(pear.horde.org/Horde_Kolab_Session) * php-pear(pear.horde.org/Horde_Ldap) * php-pear(pear.horde.org/Horde_Imsp) * php-pear(pear.horde.org/Horde_Http) [OPTIONAL] phpci: You may want to consider adding the following requires: * php-ctype * php-date * php-ftp * php-hash * php-ldap * php-pcre * php-pdo * php-spl --- NOTE: Some of these may be from the optional horde packages mentioned in the previous [OPTIONAL] so you may not need to require them if you do not require those --- NOTE: package.xml specifies "ctype" and "ftp" extensions as optional... you may want to have upstream add the additional optional extensions if they are not already required by the mentioned optional packages (I'm assuming ldap would be required by Horde_Ldap, pdo would be required by Horde_Db, etc). [OPTIONAL] package.xml lists PECL "pam" and "sasl" as optional. These are not packaged in Fedora (at least I couldn't find them). Looking at the PECL site, I'm not sure if those extensions are actively maintained or not though. If they are, you may want to package them and eventually add them as dependencies. [OPTIONAL] You may want to s/pear.horde.org/%{pear_channel}/ and then add "%global pear_channel pear.horde.org" -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review