Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: strigi - A desktop search program for KDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223586 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-08 11:41 EST ------- Created an attachment (id=147667) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147667&action=view) Mock build log of strigi-0.3.11-1.fc7 Mock build log of strigi-0.3.11-1 on FC7 i386 is attached. Well, * compiler flags - does not pass fedora specific compilation flags. * conditional dependency - Check: ------------------------------------------ -- Xerces-C was not found. ------------------------------------------ * desktop file - /usr/bin/strigiclient seems to be a GUI program and desktop file for this program should be added, perhaps. * File location - All header files under /usr/include in -devel package should be moved to %{_includedir}/%{name}. From I checked the #include entry, this is no problem and putting header files directly under /usr/include should be avoied. * Dependency - Check the dependency for -devel package. I have never checked the header files for Qt4 package. However, /usr/include/strigi/qtdbus/strigidbus.h includes: --------------------------------------------- #include <QtCore/QByteArray> --------------------------------------------- This means that -devel package should require some Qt4 related packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review