[Bug 839527] Review Request: rtirq - realtime IRQ threading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=839527

--- Comment #6 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > * I really don't like the idea to introduce another SysVinit-script. It
> > > won't be easy to switch to systemd later. 
> 
> Why is that?

It will require some %trigger magic in the spec-file. Something like this:

============
%if 0%{?fedora} > 16
%triggerun -- %{name} < 1.7.2-1
# Save the current service runlevel info
# User must manually run systemd-sysv-convert --apply opensips
# to migrate them to systemd targets
/usr/bin/systemd-sysv-convert --save %{name} >/dev/null 2>&1 ||:

# Run these because the SysV package being removed won't do them
/sbin/chkconfig --del %{name} >/dev/null 2>&1 || :
/bin/systemctl try-restart %{name}.service >/dev/null 2>&1 || :
%endif
============

It's not a blocker anyway - I just gave an advice to Brendan to avoid this
right from the start.

> I would not mind moving to systemd but Rui should be in the loop, I think. I
> considered it when rebuilding for fc17 but I had no time at all to learn
> systemd. 

Ok, let's wait for Rui then. It's not a blocker issue.

> > > ==============
> > > 
> > > [Unit]
> > > Description=Realtime IRQ thread tunning
> > > After=sound.target alsa-restore.service
> 
> Why would alsa-restore.service be a dependency? (if that is the term). Rtirq
> should happen after all kernel sound drivers are loaded and that's all it
> needs, I think. 

I'm not familiar with the application - I just thought it's a good idea to
start it right after the init of ALSA. I'm sure there is a lot of room for
improvements so consider my systemd script only as a starting point.

> > > [Service]
> > > EnvironmentFile=-/etc/sysconfig/rtirq
> > > ExecStart=/usr/bin/rtirq.sh start
> > > ExecStop=/usr/bin/rtirq.sh stop
> 
> There is also a status target that lists the current irq ordering. 

This should be handled differently. Here is a possible solution for custom
SysVinit commands:

* http://thread.gmane.org/gmane.linux.redhat.fedora.devel/166326

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]