https://bugzilla.redhat.com/show_bug.cgi?id=803089 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #31 from Michael Scherer <misc@xxxxxxxx> --- Ok, tested it, it start, it install fine, and compile. Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GENERATED FILE", "GPL (v2 or later)" For detailed output of licensecheck see file: /home/misc/checkout/git/FedoraReview/803089-whenjobs/licensecheck.txt [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Rpmlint ------- Checking: whenjobs-0.7.3-1.fc17.src.rpm whenjobs-0.7.3-1.fc17.x86_64.rpm whenjobs.src: W: spelling-error Summary(en_US) cron -> corn, con, crone whenjobs.src: W: spelling-error %description -l en_US cron -> corn, con, crone whenjobs.x86_64: E: devel-dependency ocaml-camlp4-devel whenjobs.x86_64: W: spelling-error Summary(en_US) cron -> corn, con, crone whenjobs.x86_64: W: spelling-error %description -l en_US cron -> corn, con, crone whenjobs.x86_64: W: only-non-binary-in-usr-lib whenjobs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/whenjobs/whenlib.cmxa whenjobs.x86_64: W: spurious-executable-perm /usr/lib64/whenjobs/whenlib.cmxa 2 packages and 0 specfiles checked; 1 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- whenjobs-0.7.3-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): /usr/bin/ocamlc libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libpcre.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) mailx ocaml(Arg) = 60e2cbb1ef3b8a7bfbdceb75ebf3aa31 ocaml(Array) = 720848e0b508273805ef38d884a57618 ocaml(Big_int) = ef16c44153a41f60de69bff12d11ee35 ocaml(Bigarray) = 7999848d08322c0bcb568840b1d2cf0d ocaml(Buffer) = 40bf652f22a33a7cfa05ee1dd5e0d7e4 ocaml(Camlp4) = 8701f287be2345d1e72822c94a432852 ocaml(Camlp4_config) = 6163f28f963cb16297c065b8a6e30b91 ocaml(Camlp4_import) = 9587d9e9514bd24208f106666207c953 ocaml(Char) = 3dee29b414dd26a1cfca3bbdf20e7dfc ocaml(Complex) = 9aea79838f042027ab9539d587834bc8 ocaml(Filename) = bc87b0a21cde095f477cca1f0abb32b8 ocaml(Format) = e0de312c23ff9caec6c5bfa1f44a43b4 ocaml(Hashtbl) = 9c86f7320512d6740a75017fd66156a8 ocaml(Int32) = c91c0bbb9f7670b10cdc0f2dcc57c5f9 ocaml(Int64) = 8f09e1331fe8af2d7b954585551cbe4f ocaml(Lexing) = 7d5623c54d065ad3f652261d2776959c ocaml(List) = 9c85fb419d52a8fd876c84784374e0cf ocaml(Nat) = 7ab8ce32b152977f693920f75bf5b3dc ocaml(Nativeint) = 409308ec9d1a2ab99fa91fd0dfefca97 ocaml(Netnumber) = ff99a76e025c4a87db6c6cd3fbfa192d ocaml(Netsys_mem) = 572501f17fca7a174c4e01d3a538c374 ocaml(Netsys_types) = ff27e879a1d4c7172a8b839b54db9e8c ocaml(Obj) = 3aeb33d11433c95bb62053c65665eb76 ocaml(Parsing) = 59e1db94d28f5c920aaddc6ba25fb659 ocaml(Pervasives) = db723a1798b122e08919a2bfed062514 ocaml(Printf) = 55250c391e05a095d3696890d0d554a2 ocaml(Queue) = 79fd3a55345b718296e878c0e7bed10e ocaml(Rpc_program) = 77c1f3cf557593d4dd8e9f9801dff31c ocaml(Rtypes) = b23e2fb4b78c27eb1ca98fa4058df05c ocaml(Set) = 7b178c9cf52b5cb8145441e1a0d309f5 ocaml(Stream) = cc2abcbdc5423e35862902ae0a0a4a7d ocaml(String) = 06ab5e6944c47322b9d305c0aa0b07ff ocaml(Sys) = 4fe60c54d4de0672924c1d4ee2053e46 ocaml(Unix) = 2a19929a535447ed0c8fc58ae3adc1a0 ocaml(Whenexpr) = 7d73ce460d86a777393132cb1ce474cf ocaml(Whenproto_aux) = 89e0f5b452e9faee7ffb701326792989 ocaml(Whenstate) = 56e8ed28162bad807c5429078fccbf10 ocaml(Whenutils) = 8a1526e04b66ab23387a3a4ecffed0c7 ocaml(Xdr) = 946e3e26ef24d8a2ad9840a5fd5c9433 ocaml(Xdr_mstring) = 2a94b8b145ab116df240d69864ce30df ocaml(runtime) = 3.12.1 ocaml-camlp4-devel ocaml-findlib-devel rtld(GNU_HASH) Provides -------- whenjobs-0.7.3-1.fc17.x86_64.rpm: ocaml(Config) = 22e56187c01934c5147c0c3b5e3fa721 ocaml(Pa_when) = 1183350fefb321e5a5f17e9faf5869f3 ocaml(Whenexpr) = 7d73ce460d86a777393132cb1ce474cf ocaml(Whenfile) = 6883258555279b5232ede1350a8ffb32 ocaml(Whenlock) = 4d3be5ca7c55e025f967acaaae1871d3 ocaml(Whenproto_aux) = 89e0f5b452e9faee7ffb701326792989 ocaml(Whenstate) = 56e8ed28162bad807c5429078fccbf10 ocaml(Whentools) = 6f9af1b39de525d24b8e04cb8402e6dd ocaml(Whenutils) = 8a1526e04b66ab23387a3a4ecffed0c7 whenjobs = 0.7.3-1.fc17 whenjobs(x86-64) = 0.7.3-1.fc17 MD5-sum check ------------- http://people.redhat.com/~rjones/whenjobs/files/whenjobs-0.7.3.tar.gz : MD5SUM this package : e0fe81dde02284f7e2a6da90d90def16 MD5SUM upstream package : e0fe81dde02284f7e2a6da90d90def16 Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09 Command line :./try-fedora-review -b 803089 External plugins: So good to go. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review