Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gnome-keyring-manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225820 dakingun@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dakingun@xxxxxxxxx 2007-02-08 10:15 EST ------- GOOD: * Build Ok in mock (x86_64) * License (GPL) and rpm Group tag OK * Naming meets the packaging guildlines * Spec file clean and legible * Handles locales appropriately * Buildrequires properly listed * rpmlint silent on srpm and a warning that can be ignored on the binary [deji@agape reviews]$ rpmlint gnome-keyring-manager-2.17.0-1.fc7.x86_64.rpm W: gnome-keyring-manager non-conffile-in-etc /etc/gconf/schemas/gnome-keyring-manager.schemas * Source file matches upstream 8dc9c133ccdfb2729898a05afa177a0d gnome-keyring-manager-2.17.0.tar.bz2 NEEDSWORK: * Complete url to the SOURCE is not provided. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review