[Bug 839395] Review Request: rubygem-stickshift-controller - Rails engine for the OpenShift Broker API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=839395

--- Comment #5 from David Cameron <d.g.cameron@xxxxxxxxx> ---
It looks like problems 1 and 3 are fixed, but the changelog version warning is
still there, and the spec file inside the new srpm is different from the link
in comment 3 - the Source0 tag gives a warning

rubygem-stickshift-controller.src: W: invalid-url Source0:
rubygem-stickshift-controller-git-73.1915eff.tar.gz

(the URL is ok in the standalone spec).

The new entries in the changelog also throw up new warnings:

rubygem-stickshift-controller.src:70: W: macro-in-%changelog %gemname
rubygem-stickshift-controller.src:70: W: macro-in-%changelog %gem_name
rubygem-stickshift-controller.src:70: W: macro-in-%changelog %geminstdir

I guess you want to escape those with %%.

As for the unexpanded macro warnings, this seems to be a feature related to
ruby packages and they are safe to ignore.

One more thing - the LICENSE file should be included in %doc

http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]