https://bugzilla.redhat.com/show_bug.cgi?id=839064 --- Comment #6 from Troy Dawson <tdawson@xxxxxxxxxx> --- It's looking better. First issue - Although you have a URL for the source, the tarball isn't there. Second issue ... which I don't know if it's your fault or not. I'm trying to use fedora-review to test this package. It will build in mock, but then when it starts checking the binary rpm's it fails with the following command. -------------- Build completed Run command: rpm -qpl /tmp/common/rubygem-stickshift-common/results/rubygem-stickshift-common-0.13.1-2.git.85.1915eff.fc17.noarch.rpm Exception down the road... Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 133, in run self.__do_report() File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 79, in __do_report self.__run_checks(self.bug.spec_file, self.bug.srpm_file) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 105, in __run_checks writedown=not Settings.no_report) File "/usr/lib/python2.7/site-packages/FedoraReview/checks_class.py", line 180, in run_checks if test.is_applicable(): File "/usr/lib/python2.7/site-packages/FedoraReview/checks/ccpp.py", line 13, in is_applicable self.sources_have_files('*.c') or \ File "/usr/lib/python2.7/site-packages/FedoraReview/check_base.py", line 105, in sources_have_files sources_files = self.sources.get_files_sources() File "/usr/lib/python2.7/site-packages/FedoraReview/sources.py", line 86, in get_files_sources self.extract_all() File "/usr/lib/python2.7/site-packages/FedoraReview/sources.py", line 65, in extract_all source.extract() File "/usr/lib/python2.7/site-packages/FedoraReview/source.py", line 104, in extract if not self.rpmdev_extract(self.filename, self.extract_dir): AttributeError: 'Source' object has no attribute 'filename' Exception down the road... ----------------- This output come from fedora-review-0.2.0-1.fc17 but it also fails on the latest from the git repo as well. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review