[Bug 830581] Review Request: jove - Jonathan's Own Version of Emacs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=830581

D. Hugh Redelmeier <hugh@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hugh@xxxxxxxxxx

--- Comment #11 from D. Hugh Redelmeier <hugh@xxxxxxxxxx> ---
On CentOS 5.8:
    $ rpmbuild --rebuild jove-4.16.0.73-3.fc16.src.rpm
    Installing jove-4.16.0.73-3.fc16.src.rpm
    warning: user paul does not exist - using root
    warning: group paul does not exist - using root
    error: unpacking of archive failed on file
    /repo5/hugh/rpmbuilds.kernel-2.6.18-274.7.1.el5/SPECS/jove.spec;5006c962:
cpio: MD5 sum mismatch
    error: jove-4.16.0.73-3.fc16.src.rpm cannot be installed

But it works fine on Fedora 16.  So I guess that rpm now has a different hash
but CentOS 5.8 hasn't caught up.

I think that all of Paul's changes are in the jove.spec file.

I (the upstream maintainer) would like to align your spec file with the one in
the jove source.  That doesn't need to happen now.

I like at least some of the comments that have been deleted: they help for
older or non Red Hat systems.  For example. I don't know what Suse uses for a
jove.spec file, or even if they still include it, but they did at one time.

Why did you rename README to README.doc?

I think that the empty file $RPM_BUILD_ROOT/%{_datadir}/jove/keychart. is
intentional.

You removed a bunch of %doc thingees.  I think that the result is that these
files are missing from the RPM:

-rw-r--r--. 1 root root    716 Mar 15  1994 example.rc
-rw-r--r--. 1 root root 268054 Jan  3  2012 jove.man
-rw-r--r--. 1 root root 524611 Jan  3  2012 jove.man.ps
-rw-r--r--. 1 root root   5558 Dec 18  1994 jove.qref
-rw-r--r--. 1 root root   2992 Jan 21  1995 jove.rc

They are needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]