https://bugzilla.redhat.com/show_bug.cgi?id=839395 David Cameron <d.g.cameron@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |d.g.cameron@xxxxxxxxx --- Comment #2 from David Cameron <d.g.cameron@xxxxxxxxx> --- Hi, Here is a first (informal) review: 1. The %globals in the spec file expect ruby to be already installed. Please use the pre-defined macros instead: http://fedoraproject.org/wiki/Packaging:Ruby#Macros This leads to the following rpmlint errors: rpmlint rubygem-stickshift-controller-0.14.1-1.git.26.d123083.fc18.src.rpm rubygem-stickshift-controller.src: E: specfile-error sh: ruby: command not found rubygem-stickshift-controller.src: E: specfile-error sh: ruby: command not found rubygem-stickshift-controller.src: E: specfile-error sh: ruby: command not found 1 packages and 0 specfiles checked; 3 errors, 0 warnings. 2. The changelog needs to match the release: rubygem-stickshift-controller.noarch: W: incoherent-version-in-changelog 0.14.1-1 ['0.14.1-1.git.26.d123083.fc1 8', '0.14.1-1.git.26.d123083'] 3. Other rpmlint errors: rubygem-stickshift-controller.noarch: W: no-documentation rubygem-stickshift-controller.noarch: E: script-without-shebang /builddir/.gem/ruby/1.9.1/gems/stickshift-controller-0.14.1/lib/stickshift-controller/app/models/application.rb rubygem-stickshift-controller.noarch: E: script-without-shebang /builddir/.gem/ruby/1.9.1/gems/stickshift-controller-0.14.1/lib/stickshift-controller/app/models/gear.rb rubygem-stickshift-controller.noarch: E: non-executable-script /builddir/.gem/ruby/1.9.1/gems/stickshift-controller-0.14.1/test/ddns/named_service.rb 0644L /usr/bin/ruby 4. The spec file linked in the original description is different from the spec in the 0.14.1-1 SRPM. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review