[Bug 840551] Review Request: sugar-kuku - arithmetic education game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=840551

--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ koji scratch build
->http://koji.fedoraproject.org/koji/taskinfo?taskID=4246775

- rpmlint on rpms gave
sugar-kuku.noarch: W: no-documentation
sugar-kuku.noarch: E: script-without-shebang
/usr/share/sugar/activities/KukuAnakula.activity/kuku_config.py
2 packages and 0 specfiles checked; 1 errors, 1 warnings.

+ Source verified with upstream as (sha1sum)
a424a2ed5995262aa88f2a926f06348f2b8f64fd  kuku_anakula-4.xo
a424a2ed5995262aa88f2a926f06348f2b8f64fd  ../SOURCES/kuku_anakula-4.xo

- License is GPLv3.


suggestions:
1) Change the license tag to GPLv3+
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses

2) Remove the following lines from spec
rm -rf $RPM_BUILD_ROOT
and 
%defattr(-,root,root,-)

3)Good to add documentation files as suggested in above comment.

4) fix the rpmlint error by using
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Add_shebang
in %prep.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]