https://bugzilla.redhat.com/show_bug.cgi?id=813842 --- Comment #5 from Michael Schwendt <mschwendt@xxxxxxxxx> --- > BuildRequires: gcc, make, libX11, mesa-libGL, mesa-libGLU > > I have try to build without libX11, mesa-libGL, mesa-libGLU and rpm > do not found the dependencies What does that mean? What failure and when? Please explain. It's unusual that your BuildRequires do not contain "libX11-devel mesa-libGL-devel mesa-libGLU-devel" instead. > %package devel > BuildRequires: libX11-devel, mesa-libGL-devel, mesa-libGLU-devel There they are! That's not a good place where to put BuildRequires. For optional (!) subpackages, it may be suitable to mention the additional BR near to the subpackage section of the spec file. But for essential subpackages such as -devel that only adds confusion. As could be seen during this review. ;) > Curently i provides static lib as shared lib build is broken How is it broken? Why do you include the shared lib in the package if you know it's broken? > Requires: %{name} = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %build > make %{?_smp_mflags} x11 > > ... > > %install > make %{?_smp_mflags} x11-dist-install PREFIX=/usr LIBDIR=%{_lib} > DESTDIR=%{buildroot} CFLAGS="$RPM_OPT_FLAGS" That asks for a closer look. Why do you add CFLAGS for "install" but not "build". Nothing ought to be compiled anymore in the %install section. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review