https://bugzilla.redhat.com/show_bug.cgi?id=738742 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |vondruch@xxxxxxxxxx Flags| |fedora-review+ --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * The test should be expanded in %check section - I would prefer if the test suite is expanded in the %check section, since in that case, you will avoid the RPM polution. Although admittedly, the %patch macro does not work there, but you can use something like: cat %{PATCH0} | patch -p1 Since this is just minor nit and the package looks reasonable otherwise, I APPROVE the package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review