https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #22 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- So, I just looked closer at the gnome-common analog, http://pkgs.fedoraproject.org/gitweb/?p=gnome-common.git;a=blob;f=gnome-common.spec and see some things we could... borrow here. :) stuff like: runtime requires better summary/description so, 1. MUST: add runtime deps Requires: automake autoconf libtool gettext pkgconfig 2. SHOULD: improve pkg summary/description as suggested 3. MUST: Licensing: so, .spec says GPLv2+, and none of the included files mention licensing, except for the embedded COPYING file, which is GPLv3. can you verify with upstream (if you haven't already), their intent here? (I'm assuming some GPLv2+ (with some/all libs LGPLv2+) combo like pre-forked gnome2...) naming: ok macros: ok scriptlets: n/a sources: ok $ md5sum *.xz bc49ff6897ef2303c6464a3ca46aaf35 mate-common-1.4.0.tar.xz -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review