https://bugzilla.redhat.com/show_bug.cgi?id=803558 Matt Spaulding <mspaulding06@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Matt Spaulding <mspaulding06@xxxxxxxxx> --- (In reply to comment #4) > hi > > 3. Ask upstream to include a LICENSE file. Some of the test source files do not have license headers. You might mention that to them as well. > is available in src/assemble/EHCACHE-CORE-LICENSE.txt > http://ehcache.org/about/license Thanks for catching my mistake here. Didn't see that file. > > > 5. There is a newer version available (2.5.2). Not required; but if the change is trivial, you should update to the latest version. > there is a new version available > http://svn.terracotta.org/svn/ehcache/tags/ehcache-core-2.6.0 > the source rpm is available here http://gil.fedorapeople.org/ Looked at your new 2.6.0 package. Everything looks good and all issues are corrected. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review