[Bug 837313] Review Request: gssproxy - A proxy for GSSAPI credential handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=837313

--- Comment #8 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> ---
This package still doesn't look like it has been properly reviewed.  Andreas,
there's many templates out there of what needs to be checked on review that you
could use (for instance:
https://fedoraproject.org/wiki/User:Tibbs/Review_Template ).  You can also just
use http://fedoraproject.org/wiki/Packaging:ReviewGuidelines and post that in
checklist form.  If you aren't checking at least the things mentioned in the
Packaging Guidelines, then you aren't doing a proper review.  So far, your
reviews don't appear to have done that (as you missed easily spotted things
after your initial review in Comment #1 and your followup in Comment #6 doesn't
say that you then checked the package against the Guidelines, only that you
built it and installed it.)

If you are doing the full review just not writing it down, also remember that
the package review is a means of communication.  If you don't write down what
has been checked, what was good, and what was bad, you aren't recording
information on the package that people may need later when figuring out why or
when a package started doing something wrong.

Guenther, please don't build this package until Andreas has done a full review
-- I see at least one other thing that Andreas hasn't done which should lead to
either a change in %files or a comment about why it is the way it is.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]