https://bugzilla.redhat.com/show_bug.cgi?id=839104 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #5 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+ or CC-BY-SA) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: c3f3b17ec196a53c70bf8cea6d0fd67c shimmerproject-Bluebird-v0.6-1-g5aa322d.tar.gz c3f3b17ec196a53c70bf8cea6d0fd67c shimmerproject-Bluebird-v0.6-1-g5aa322d.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: bluebird.src: W: spelling-error Summary(en_US) minimalistic -> minimalist, minimalism, animistic bluebird.src: W: spelling-error %description -l en_US metacity -> meta city, meta-city, mendacity bluebird.src: W: spelling-error %description -l en_US xfwm bluebird.src: W: invalid-url Source0: shimmerproject-Bluebird-v0.6-1-g5aa322d.tar.gz can all be ignored. bluebird.src: E: description-line-too-long C Bluebird is a theme for GTK2/3 and xfwm4/metacity. The GTK+ theme is based on Zuki Blues, and the xfwm theme is based on axiom. 5 packages and 0 specfiles checked; 1 errors, 4 warnings. Some word wrapping action needed? Thats pretty minor and can be fixed before import... I don't see any blockers, so this package is APPROVED. I will go ahead and sponsor you in and go look at finishing the albatross review. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review