Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: ncpfs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226186 mitr@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review- | ------- Additional Comments From mitr@xxxxxxxxxx 2007-02-08 00:38 EST ------- Thanks! W: ncpfs no-url-tag FTP URL added W: ncpfs devel-file-in-non-devel-package /usr/lib/libncp.so W: ncpfs devel-file-in-non-devel-package /usr/include/ncp/obsolete/o_ndslib.h > And many more .h files. These should all be placed into a separate -devel > subpackage. Done. E: ncpfs setuid-binary /usr/bin/ncplogin root 04755 E: ncpfs non-standard-executable-perm /usr/bin/ncplogin 04755 > A couple like these. I suppose these are necessary, but has anyone looked > at the security issues? A few security issues in ncpfs have been discovered, so at least someone has :) X build root is not correct; should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Fixed. X unversioned .so files should be in -devel subpackage. X headers present and should be in -devel package. Both fixed. Please review ncpfs-2.2.6-7. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review