[Bug 839064] Review Request: rubygem-stickshift-common - OpenShift Origin library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=839064

Troy Dawson <tdawson@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tdawson@xxxxxxxxxx

--- Comment #2 from Troy Dawson <tdawson@xxxxxxxxxx> ---
Informal Review:
Don't forget to include rubygem-devel.
Please use the macro's that are included in rubygems-devel.
https://fedoraproject.org/wiki/Packaging/Ruby#Macros

Using the new way of building gems in rpms will help keep rubygem packages more
uniform.
https://fedoraproject.org/wiki/Packaging/Ruby#Building_gems

Please attach an rpmlint output.  Here is what I got

$ rpmlint rubygem-stickshift-common.spec
rubygem-stickshift-common.spec: E: specfile-error -e:1: Use RbConfig instead of
obsolete and deprecated Config.
rubygem-stickshift-common.spec: E: specfile-error -e:1: Use RbConfig instead of
obsolete and deprecated Config.
0 packages and 1 specfiles checked; 2 errors, 0 warnings.

$ rpmlint rubygem-stickshift-common-0.13.1-1.src.rpm
rubygem-stickshift-common.src: W: non-coherent-filename
rubygem-stickshift-common-0.13.1-1.src.rpm
rubygem-stickshift-common-0.13.1-1.git.45.ecfb399.fc16.src.rpm
rubygem-stickshift-common.src: E: specfile-error -e:1: Use RbConfig instead of
obsolete and deprecated Config.
rubygem-stickshift-common.src: E: specfile-error -e:1: Use RbConfig instead of
obsolete and deprecated Config.
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

It looks like if you use the rubygems-devel %{ruby_sitelibdir} instead of the
one you have in %global, the RBCongif error will go away.

Also, your src.rpm should be named
rubygem-stickshift-common-0.13.1-1.git.45.ecfb399.fc16.src.rpm
I'm not sure if you changed the name intentionaly or not, but you should keep
the rpm names what they are supposed to be.  It might look better for the
moment, but it causes confusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]