https://bugzilla.redhat.com/show_bug.cgi?id=839653 Troy Dawson <tdawson@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tdawson@xxxxxxxxxx --- Comment #1 from Troy Dawson <tdawson@xxxxxxxxxx> --- Informal Review: The spec file should match the rpm name (rubygem-slim.spec) The License is MIT You should attach an rpmlint to this review request $ rpmlint slim.spec rubygem-slim-1.2.2-1.fc17.src.rpm rubygem-slim.src: E: invalid-spec-name 1 packages and 1 specfiles checked; 1 errors, 0 warnings. Other than that, this looks very good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review