https://bugzilla.redhat.com/show_bug.cgi?id=755510 --- Comment #27 from Jeff Peeler <jpeeler@xxxxxxxxxx> --- This mostly looks good, a few next steps: 1) Remove defattr as it is not required. 2) The github downloading stuff looks weird. I'm not sure where the gitsub part came from (although I'm also in the process of working this out for another package myself). Can you make your Source URL mirror the same format used in these other gnome shell extensions? http://pkgs.fedoraproject.org/gitweb/?p=gnome-shell-extension-pomodoro.git;a=blob;f=gnome-shell-extension-pomodoro.spec;h=9eda6cca73b165ad6f0ab392cf740eae45a87aef;hb=f17 http://pkgs.fedoraproject.org/gitweb/?p=gnome-shell-extension-pidgin.git;a=blob;f=gnome-shell-extension-pidgin.spec;h=971ad94b5ef0868c2b47648735f3223c64646404;hb=f17 3) The translation stuff looks like it could be greatly simplified using find -exec. 4) I think it's policy to not restart gnome shell automatically, so go ahead and remove the post scriptlets. You should also show the upstream maintainer this review, just for awareness. I'll do a complete (unofficial) package review once all these things are completed. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review