Bug 226513: Merge Review: units Product: Fedora Extras Version: devel Component: Package Review Kevin Fenzi <kevin@xxxxxxxxx> has denied Kevin Fenzi <kevin@xxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226513 ------- Additional Comments from Kevin Fenzi <kevin@xxxxxxxxx> OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: e27f580474702e9138b332acbafafe5b units-1.86.tar.gz e27f580474702e9138b332acbafafe5b units-1.86.tar.gz.1 See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. See below - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version 0 outstanding bugs - check for outstanding bugs on package. Issues: 1. Might include in %doc: ChangeLog COPYING NEWS README 2. Buildroot should be the default one: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 3. rpmlint says: rpmlint on units-1.86-3.fc7.src.rpm W: units summary-ended-with-dot A utility for converting amounts from one unit to another. Suggest: remove . at the end of summary. W: units no-url-tag Suggest: add a "URL: http://www.gnu.org/software/units/units.html"; W: units prereq-use /sbin/install-info Suggest: remove the "Prereq: /sbin/install-info" and replace per http://www.fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb26 62d75deefeb9ba75145a398515db with Requires(post): /sbin/install-info Requires(preun): /sbin/install-info 4. Don't use %makeinstall, instead use 'make DESTDIR=$RPM_BUILD_ROOT install' per http://www.fedoraproject.org/wiki/PackagingDrafts/MakeInstall 5. Possible missing Buildrequires? checking for sin... no checking for tparm in -lncurses... no checking for tgetent in -ltermcap... no checking for readline in -lreadline... no Once you have addressed these items (either by making the suggested changes, or by explaining why they don't make sense), please reassign this review back to me, and change the 'fedora-review' flag back to ? for me to take action. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review