https://bugzilla.redhat.com/show_bug.cgi?id=828544 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to comment #12) > I believe megaglest-data should be the owner of %{_datadir}/megaglest (what > was removed in the previous change, and megaglest lists > %{_datadir}/megaglest/*). > megaglest-data is supposed to be installed before megaglest, that is or > should be the reason megaglest-data does not require megaglest, but > megaglest requires megaglest-data. Ok, to me is fine as long the 2 packages go along. Also listing as you did: %files %doc docs/* %dir %{_datadir}/megaglest %{_datadir}/megaglest/configuration.xml %{_datadir}/megaglest/data/ %{_datadir}/megaglest/glest* %{_datadir}/megaglest/maps/ %{_datadir}/megaglest/megaglest.bmp %{_datadir}/megaglest/scenarios/ %{_datadir}/megaglest/techs/ %{_datadir}/megaglest/tilesets/ %{_datadir}/megaglest/tutorials/ Is the same as: %files %doc docs/* %{_datadir}/megaglest Because the "ownership" is generated at build time, and the resulting rpm is identical in both cases. If you prefer, the verbose one is fine. (In reply to comment #13) > Spec URL: http://fedorapeople.org/~pcpa/megaglest-data.spec > SRPM URL: http://fedorapeople.org/~pcpa/megaglest-data-3.6.0.3-3.fc18.src.rpm You can also specify urls this way: http://pcpa.fedorapeople.org/ Package approved! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review