https://bugzilla.redhat.com/show_bug.cgi?id=838720 Reiner Rottmann <reiner@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |reiner@xxxxxxxxxxx --- Comment #2 from Reiner Rottmann <reiner@xxxxxxxxxxx> --- This is an unofficial review, as I need sponsoring myself: The spec file is rather clean and there is not much to complain. I've checked the following items: - source files match upstream: OK 994a69f1590b37d9447412f979555f28fc5b20259145f5fd698c2b4bcd3360b9 - package meets naming and versioning guidelines: OK - specfile is properly named, is cleanly written and uses macros consistently: OK - dist tag is present: OK - build root is correct: OK - using the default. (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is the recommended value, but not the only one) - license field matches the actual license: OK? GPLv2 is correct. It is duallicensed: "you can choose between the GNU Public License (GPL) Version 2 and the FreeType License (FTL.)" - license is open source-compatible: OK - license text included in package: OK - latest version is being packaged: OK? Current version: 0.91 (12th July 2012). Packaged: 0.9 - BuildRequires are proper: OK - compiler flags are appropriate: OK - %clean is present: NO - package builds in mock: OK INFO: mock.py version 1.1.22 starting... State Changed: init plugins INFO: selinux enabled State Changed: start INFO: Start(../SRPMS/ttfautohint-0.9-1.fc17.src.rpm) Config(fedora-17-x86_64) State Changed: lock buildroot State Changed: clean INFO: chroot (/var/lib/mock/fedora-17-x86_64) unlocked and deleted State Changed: unlock buildroot State Changed: init State Changed: lock buildroot Mock Version: 1.1.22 INFO: Mock Version: 1.1.22 INFO: calling preinit hooks INFO: enabled root cache State Changed: unpacking root cache INFO: enabled yum cache State Changed: cleaning yum metadata INFO: enabled ccache State Changed: running yum State Changed: unlock buildroot INFO: Installed packages: State Changed: setup State Changed: build INFO: Done(../SRPMS/ttfautohint-0.9-1.fc17.src.rpm) Config(default) 6 minutes 9 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-17-x86_64/result State Changed: end - package installs properly: OK - debuginfo package looks complete: OK - rpmlint is silent: NO [rottmrei@fedora SPECS]$ rpmlint ../RPMS/x86_64/ttfautohint-0.9-1.fc17.x86_64.rpm ttfautohint.x86_64: W: summary-not-capitalized C ttfautohint's goal is a 99% automated hinting process for web fonts, acting as a platform for finely hand-tuned hinting. ttfautohint.x86_64: W: summary-ended-with-dot C ttfautohint's goal is a 99% automated hinting process for web fonts, acting as a platform for finely hand-tuned hinting. ttfautohint.x86_64: E: summary-too-long C ttfautohint's goal is a 99% automated hinting process for web fonts, acting as a platform for finely hand-tuned hinting. ttfautohint.x86_64: E: description-line-too-long C ttfautohint's goal is a 99% automated hinting process for web fonts, acting as a platform for finely hand-tuned hinting. ttfautohint.x86_64: E: changelog-time-in-future 2012-07-09 ttfautohint.x86_64: W: no-documentation ttfautohint.x86_64: W: no-manual-page-for-binary ttfautohint ttfautohint.x86_64: W: no-manual-page-for-binary ttfautohintGUI 1 packages and 0 specfiles checked; 3 errors, 5 warnings. - final provides and requires are sane: OK [rottmrei@fedora SPECS]$ rpm -qp --provides ../RPMS/x86_64/ttfautohint-0.9-1.fc17.x86_64.rpm ttfautohint = 0.9-1.fc17 ttfautohint(x86-64) = 0.9-1.fc17 [rottmrei@fedora SPECS]$ rpm -qp --requires ../RPMS/x86_64/ttfautohint-0.9-1.fc17.x86_64.rpm freetype libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review