https://bugzilla.redhat.com/show_bug.cgi?id=741529 --- Comment #4 from Simone Caronni <negativo17@xxxxxxxxx> --- Issues: * Project URL: The main project's website is at the following url: http://code.google.com/p/pythonfutures/ But the python guidelines specify a different addres for python packages, so I let you decide which one to put: http://fedoraproject.org/wiki/Packaging:Python#Example_spec_file * EPEL 5 rpmlint: [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 These are ok if you plan to build also for EPEL 5; otherwise please remove them. * Spelling rpmlint: [!]: MUST Rpmlint output is silent. python-futures.src: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backpacker python-futures.src: W: spelling-error %description -l en_US callables -> callable, callable s, calculable python-futures.noarch: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backpacker python-futures.noarch: W: spelling-error %description -l en_US callables -> callable, callable s, calculable These can be ignored. * Spec file: - Please add a space between %install and %clean sections. - According to the python packaging guidelines, you can shorten the file section and the BuildRequires should be a bit different: http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review