https://bugzilla.redhat.com/show_bug.cgi?id=839119 --- Comment #7 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+ or CC-BY-SA) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream sha256sum: 93b5b9bfebc7f75f25f9f62a6e0593d41e95e7724f4d24fcf9d3fa13e615a626 shimmerproject-Albatross-v1.2-6-g6fead95.tar.gz 93b5b9bfebc7f75f25f9f62a6e0593d41e95e7724f4d24fcf9d3fa13e615a626 shimmerproject-Albatross-v1.2-6-g6fead95.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. There's a bit of Release confusion going on. You have: Release: 4%{?dist} but the changelog has: * Tue Jul 10 2012 Jayson Rowe <jaysonr@xxxxxxxxxxxxxxxxx> 1.2-6 I'd suggest both should be 1 initally, then 2, etc. So, if you could fix the above changelog entry to be 1.2-1, then add a new 1.2-2 for the changes from this review, that would be great. 2. rpmlint says: Can be ignored: albatross.src: W: spelling-error %description -l en_US metacity -> meta city, meta-city, mendacity albatross.src: W: spelling-error %description -l en_US colour -> color, co lour, co-lour Can you trim the description down some: albatross.src: E: description-line-too-long C Albatross is a theme for GTK2/3 and xfwm4/metacity. The Albatross GTK theme is designed upon the Alvaro theme, from James Schriver. Albatross is designed to be smooth: no rough borders, no contrasted edges, no violent contrasts, a soft blue colour. Albatross currently uses a slightly modified version of Xfwm4.6′s default window decorations, made by Olivier Fourdan. As mentioned, this one can be ignored: albatross.src: W: invalid-url Source0: shimmerproject-Albatross-v1.2-6-g6fead95.tar.gz 5 packages and 0 specfiles checked; 1 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review