https://bugzilla.redhat.com/show_bug.cgi?id=838327 --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (ASL 2.0) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream sha256sum: 8d51fe8661bf407433db6c0fa12e3c6c66a1cd626751f51b170990089dc966a8 iXhash2-2.05.tar.gz 8d51fe8661bf407433db6c0fa12e3c6c66a1cd626751f51b170990089dc966a8 iXhash2-2.05.tar.gz.orig See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Build seems to fail here: + perldoc iXhash2.pm /var/tmp/rpm-tmp.X9jg0p: line 43: perldoc: command not found error: Bad exit status from /var/tmp/rpm-tmp.X9jg0p (%install) Adding perl-Pod-Perldoc to BuildRequires seems to fix it. 2. rpmlint says: spamassassin-iXhash2.noarch: W: spelling-error Summary(en_US) lookup -> lockup, hookup, look up spamassassin-iXhash2.noarch: W: spelling-error Summary(en_US) checksums -> check sums, check-sums, checks spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US iXhash -> ix hash, ix-hash, hashish spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US async -> sync, a sync spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US lookups -> lockups, hookups, look ups spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks spamassassin-iXhash2.src: W: spelling-error Summary(en_US) lookup -> lockup, hookup, look up spamassassin-iXhash2.src: W: spelling-error Summary(en_US) checksums -> check sums, check-sums, checks spamassassin-iXhash2.src: W: spelling-error %description -l en_US iXhash -> ix hash, ix-hash, hashish spamassassin-iXhash2.src: W: spelling-error %description -l en_US async -> sync, a sync spamassassin-iXhash2.src: W: spelling-error %description -l en_US lookups -> lockups, hookups, look ups spamassassin-iXhash2.src: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks All can be ignored. spamassassin-iXhash2.noarch: W: self-obsoletion spamassassin-iXhash < 1.5.6-1 obsoletes spamassassin-iXhash = 1.5.5-2 Is there a reason for this? spamassassin-iXhash2.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 1) Cosmetic, clean up if you like. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review