https://bugzilla.redhat.com/show_bug.cgi?id=837268 jiri vanek <jvanek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from jiri vanek <jvanek@xxxxxxxxxx> --- hi! Thank you for very careful review! most issues have been fixed: http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager.spec http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-1-1.fc16.src.rpm http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-1-1.fc16.noarch.rpm http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-javadoc-1-1.fc16.noarch.rpm namely: cp -r dist/javadoc/* $RPM_BUILD_ROOT%{_javadocdir}/%{name} FIXED - added asterix the subpackage javadoc should got the license file and remove the %%defattr(-,root,root,-) This is OK if FIXED - both edit /%{_datadir}/%{name} FIXED - removed leading slash [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL FIXED - clean removed [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files javadoc section. This is OK if packaging for EPEL5. Otherwise not needed FIXED - global defattr removed Two not fixed: 1) See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 and Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install REASON: I must be blind but there is already %install rm -rf $RPM_BUILD_ROOT ... 2)[!]: MUST Rpmlint output is silent. rpmlint CardManager-1-1.fc18.noarch.rpm CardManager.noarch: W: spelling-error %description -l en_US multiplatform -> multiform, formulation, formulator CardManager.noarch: W: spelling-error %description -l en_US downloadable -> down loadable, down-loadable, download able CardManager-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, CardManager.noarch: W: no-manual-page-for-binary CardManager CardManager.noarch: E: use-of-home-in-%post CardManager.noarch: E: use-of-home-in-%postun CardManager.noarch: W: uncompressed-zip /usr/share/java/CardManager.jar Well this rule was added recently and is going to be removed or touched as to strict. I hope I have good excuse for all issues by rpmlint: 2.a multiplatform - I consider this word as correct 2.b downloadable - likewise 2.c Javadocs - likewise - copy-pasted from guidelines anyway;) 2.d no-manual-page-for-binary - gui application with own gui-help 2.e uncompressed-zip - what I can see in rpm is zip with mor ethen 50% of compression. Bug in rpmlint? 2.f CardManager.noarch: E: use-of-home-in-%postun and %post - This is most discusable issue. I'm using it just for echo so I believe that it can stay in as serving good purpose. However, if you really insist I will remove it. Thank you for your review again! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review