https://bugzilla.redhat.com/show_bug.cgi?id=838870 --- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- (In reply to comment #2) > * Rename %{fedorarel} to %{release} > - Not a show stopper, but the %{release} macro is supported by > rpmdev-bumpspec, > so the updated release is not appended at the end of Release string. > Ah, yes. Will do before commiting to dist-git. > * The "Rakefile shouldn't be executable" comment is misleading > - Since the file is not executable, but you are just removing shebang > You are right, I will fix that as well > Nonetheless, these are just minor nits, so I'll approve the package as soon > as the rubygem-ref is available in the Rawhide and I'll be able to test the > Koji build (it builds just fine locally). Here is the koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4235854 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review