https://bugzilla.redhat.com/show_bug.cgi?id=819264 --- Comment #27 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- rdieter, maybe the fedora-cvs request was not yet processed because you did not do a full fedora-review :-) The package is mine, so, not changing the generated review: $ fedora-review -b 819264 Processing review bug : 819264 Getting .spec and .srpm Urls from bug report : 819264 Downloading .spec and .srpm files Building /home/pcpa/819264/Singular-3.1.3-6.fc18.src.rpm using mock fedora-rawhide-i386 INFO: mock.py version 1.1.23 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run INFO: Start(/home/pcpa/819264/Singular-3.1.3-6.fc18.src.rpm) Config(fedora-rawhide-i386) Start: lock buildroot Start: clean chroot INFO: chroot (/var/lib/mock/fedora-rawhide-i386) unlocked and deleted Finish: clean chroot Finish: lock buildroot Start: chroot init Start: lock buildroot Mock Version: 1.1.23 INFO: Mock Version: 1.1.23 INFO: calling preinit hooks INFO: enabled root cache Start: unpacking root cache Finish: unpacking root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Start: device setup Finish: device setup Start: yum update Finish: yum update Finish: lock buildroot Finish: chroot init INFO: Installed packages: Start: build phase for Singular-3.1.3-6.fc18.src.rpm Start: device setup Finish: device setup Start: build setup for Singular-3.1.3-6.fc18.src.rpm Finish: build setup for Singular-3.1.3-6.fc18.src.rpm Start: rpmbuild -bb Singular-3.1.3-6.fc18.src.rpm Finish: rpmbuild -bb Singular-3.1.3-6.fc18.src.rpm Finish: build phase for Singular-3.1.3-6.fc18.src.rpm INFO: Done(/home/pcpa/819264/Singular-3.1.3-6.fc18.src.rpm) Config(fedora-rawhide-i386) 6 minutes 16 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-i386/result Finish: run Build completed ok Downloading (Source0): http://www.mathematik.uni-kl.de/ftp/pub/Math/Singular/SOURCES/3-1-3/Singular-3-1-3-3.tar.gz Running checks and generate report Checking source md5 : /home/pcpa/819264/Singular-3-1-3-3.tar.gz Review in: /home/pcpa/819264/Singular-review.txt and the Singular-review.txt: ---%<--- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [ ]: MUST Package does not contain kernel modules. [ ]: MUST Package contains no static executables. [ ]: MUST Rpath absent or only used for internal libs. [ ]: MUST Package is not relocatable. [!]: MUST Development (unversioned) .so files in -devel subpackage, if present. Note: Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/dbmsr.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldGeneral.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldIndep.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldQ.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldZp.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/libsingular.so [ ]: MUST Static libraries in -static subpackage, if present. ==== Generic ==== [ ]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [ ]: MUST Package contains no bundled libraries. [ ]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [ ]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [ ]: MUST Package requires other packages for directories it uses. [ ]: MUST Package uses nothing in %doc for runtime. [ ]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [ ]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: MUST License field in the package spec file matches the actual license. [ ]: MUST License file installed when any subpackage combination is installed. [ ]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [ ]: MUST Package does not generate any conflict. [ ]: MUST Package obeys FHS, except libexecdir and /usr/target. [ ]: MUST Package must own all directories that it creates. [ ]: MUST Package does not own files or directories owned by other packages. [ ]: MUST Package installs properly. [ ]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint Singular-3.1.3-6.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint Singular-doc-3.1.3-6.fc18.i686.rpm Singular-doc.i686: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint libfac-devel-3.1.3-6.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint Singular-devel-3.1.3-6.fc18.i686.rpm Singular-devel.i686: W: no-documentation Singular-devel.i686: E: incorrect-fsf-address /usr/include/singular/fegetopt.h Singular-devel.i686: W: spurious-executable-perm /usr/include/libsingular.h Singular-devel.i686: E: incorrect-fsf-address /usr/include/singular/grammar.h 1 packages and 0 specfiles checked; 2 errors, 2 warnings. rpmlint Singular-examples-3.1.3-6.fc18.i686.rpm Singular-examples.i686: W: only-non-binary-in-usr-lib Singular-examples.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint Singular-3.1.3-6.fc18.i686.rpm Singular.i686: W: no-soname /usr/lib/libsingular.so Singular.i686: W: file-not-utf8 /usr/lib/Singular/COPYING Singular.i686: E: incorrect-fsf-address /usr/lib/Singular/GPL2 Singular.i686: W: no-manual-page-for-binary TSingular Singular.i686: W: no-manual-page-for-binary Singular 1 packages and 0 specfiles checked; 1 errors, 4 warnings. rpmlint Singular-emacs-3.1.3-6.fc18.i686.rpm Singular-emacs.i686: W: no-documentation Singular-emacs.i686: W: no-manual-page-for-binary ESingular 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint Singular-debuginfo-3.1.3-6.fc18.i686.rpm Singular-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/Singular-3-1-3/Singular/grammar.cc Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/Singular/janet.cc Singular-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/Singular-3-1-3/Singular/janet.h Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/factory/facAlgExt.cc Singular-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/Singular-3-1-3/kernel/fegetopt.h Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/factory/cf_gcd_smallp.cc Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/factory/facIrredTest.cc Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/Singular/wrapper.cc 1 packages and 0 specfiles checked; 7 errors, 1 warnings. rpmlint Singular-surfex-3.1.3-6.fc18.i686.rpm Singular-surfex.i686: W: only-non-binary-in-usr-lib Singular-surfex.i686: W: no-documentation Singular-surfex.i686: W: no-manual-page-for-binary surfex 1 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint factory-devel-3.1.3-6.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/pcpa/819264/Singular-3-1-3-3.tar.gz : MD5SUM this package : 37e532fb6cece957e90a4be9ad1d375b MD5SUM upstream package : 37e532fb6cece957e90a4be9ad1d375b [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [ ]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [ ]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [ ]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: SHOULD Package functions as described. [ ]: SHOULD Latest version is packaged. [ ]: SHOULD Package does not include license text files separate from upstream. [ ]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0: http://www.mathematik.uni- kl.de/ftp/pub/Math/Singular/SOURCES/3-1-3/Singular-3-1-3-3.tar.gz (Singular-3-1-3-3.tar.gz) Patch0: Singular-python.patch (Singular- python.patch) Patch1: Singular-make-parallel.patch (Singular-make- parallel.patch) Patch2: Singular-shared.patch (Singular-shared.patch) Patch3: Singular-destdir.patch (Singular-destdir.patch) Patch4: Singular- headers.patch (Singular-headers.patch) Patch5: Singular-link.patch (Singular-link.patch) Patch6: Singular-doc.patch (Singular-doc.patch) Patch7: Singular-builddid.patch (Singular-builddid.patch) Patch8: Singular-undefined.patch (Singular-undefined.patch) [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. ==== Java ==== [ ]: MUST If source tarball includes bundled jar/class files these need to be removed prior to building [!]: MUST Packages have proper BuildRequires/Requires on jpackage-utils [x]: MUST Fully versioned dependency in subpackages, if present. [!]: MUST Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present [!]: MUST Javadoc subpackages have Requires: jpackage-utils [!]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present [ ]: SHOULD Package has BuildArch: noarch (if possible) [ ]: SHOULD Package uses upstream build method (ant/maven/etc.) ==== Maven ==== [x]: MUST Old add_to_maven_depmap macro is not being used [ ]: MUST If package contains pom.xml files install it (including depmaps) even when building with ant Issues: [!]: MUST Rpmlint output is silent. rpmlint Singular-3.1.3-6.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint Singular-doc-3.1.3-6.fc18.i686.rpm Singular-doc.i686: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint libfac-devel-3.1.3-6.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint Singular-devel-3.1.3-6.fc18.i686.rpm Singular-devel.i686: W: no-documentation Singular-devel.i686: E: incorrect-fsf-address /usr/include/singular/fegetopt.h Singular-devel.i686: W: spurious-executable-perm /usr/include/libsingular.h Singular-devel.i686: E: incorrect-fsf-address /usr/include/singular/grammar.h 1 packages and 0 specfiles checked; 2 errors, 2 warnings. rpmlint Singular-examples-3.1.3-6.fc18.i686.rpm Singular-examples.i686: W: only-non-binary-in-usr-lib Singular-examples.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint Singular-3.1.3-6.fc18.i686.rpm Singular.i686: W: no-soname /usr/lib/libsingular.so Singular.i686: W: file-not-utf8 /usr/lib/Singular/COPYING Singular.i686: E: incorrect-fsf-address /usr/lib/Singular/GPL2 Singular.i686: W: no-manual-page-for-binary TSingular Singular.i686: W: no-manual-page-for-binary Singular 1 packages and 0 specfiles checked; 1 errors, 4 warnings. rpmlint Singular-emacs-3.1.3-6.fc18.i686.rpm Singular-emacs.i686: W: no-documentation Singular-emacs.i686: W: no-manual-page-for-binary ESingular 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint Singular-debuginfo-3.1.3-6.fc18.i686.rpm Singular-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/Singular-3-1-3/Singular/grammar.cc Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/Singular/janet.cc Singular-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/Singular-3-1-3/Singular/janet.h Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/factory/facAlgExt.cc Singular-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/Singular-3-1-3/kernel/fegetopt.h Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/factory/cf_gcd_smallp.cc Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/factory/facIrredTest.cc Singular-debuginfo.i686: E: script-without-shebang /usr/src/debug/Singular-3-1-3/Singular/wrapper.cc 1 packages and 0 specfiles checked; 7 errors, 1 warnings. rpmlint Singular-surfex-3.1.3-6.fc18.i686.rpm Singular-surfex.i686: W: only-non-binary-in-usr-lib Singular-surfex.i686: W: no-documentation Singular-surfex.i686: W: no-manual-page-for-binary surfex 1 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint factory-devel-3.1.3-6.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: MUST Development (unversioned) .so files in -devel subpackage, if present. Note: Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/dbmsr.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldGeneral.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldIndep.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldQ.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/Singular/p_Procs_FieldZp.so Singular-3.1.3-6.fc18.i686.rpm : /usr/lib/libsingular.so See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages [!]: MUST Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java [!]: MUST Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation [!]: MUST Javadoc subpackages have Requires: jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java [!]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation Generated by fedora-review 0.1.3 External plugins: ---%<--- -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review