[Bug 838621] Review Request: perl-ServiceNow-API - ServiceNow API for accessing the Service-now platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=838621

--- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> ---
* Correctly named
* Packing latest version
* License is correctly specified and a free license
* SPEC file clean and legible

- Distribution link broken!
        CPAN one does not exist: http://search.cpan.org/dist/ServiceNow-API/
        Did you mean this? http://wiki.servicenow.com/index.php?title=Perl_API

- Unpacking fails, since the zifile contains a "__MACOSX/" toplevel directory:
        + /usr/bin/unzip -qq
/home/lkundrak/rpmbuild/SOURCES/ServiceNow-Perl-API.zip
        replace __MACOSX/ServiceNow-1.01/._.DS_Store? [y]es, [n]o, [A]ll,
[N]one, [r]ename:

        You may want to use the following %prep instead to add a level in
hierarchy
        %setup -q -c -n %{name}-%{version}
        %setup -D -T -q -n %{name}-%{version}/ServiceNow-%{version}

- You're missing a BR for testing: BuildRequires: perl(Test::Pod::Coverage)

- POD tests fail if coverage test module is installed:
        t/pod-coverage.t .. 1/19
        #   Failed test 'Pod coverage on ServiceNow'
        #   at /usr/share/perl5/Test/Pod/Coverage.pm line 126.
        # Coverage for ServiceNow is 96.4%, with 1 naked subroutine:
        #       createNotification

- Empty %doc 
        You may want to include README, etc.

- Rebuild for 5.16 in changelog?
        You may want to remove that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]