[Bug 838870] Review Request: rubygem-therubyracer - Embed the V8 Javascript interpreter into Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=838870

--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Rename %{fedorarel} to %{release}
  - Not a show stopper, but the %{release} macro is supported by
rpmdev-bumpspec,
    so the updated release is not appended at the end of Release string.

* The "Rakefile shouldn't be executable" comment is misleading
  - Since the file is not executable, but you are just removing shebang

Nonetheless, these are just minor nits, so I'll approve the package as soon as
the rubygem-ref is available in the Rawhide and I'll be able to test the Koji
build (it builds just fine locally).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]