https://bugzilla.redhat.com/show_bug.cgi?id=808350 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx Whiteboard| |BuildFails --- Comment #5 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- I went ahead and closed the other bug since it's long since gone idle and there's no point in having two review tickets for the same thing. This package isn't really in my field of expertise but I'm just popping my head in here to try and get things moving Could you comment on the bundling issues mentioned in bug 676124? There seems to be come confusion about what URL: and the SourceN: tags are for. URL: should contain a URL for the upstream web site, so you can just visit it with your browser to get more information. Source0: should have the full URL to the tarball. Have you worked out with the rpm maintainers why disabling the debug package is necessary? This seems like a bug somewhere, and if you're going to do this you should at least be able to point to a filed bug or some mailing list discussion or something. No Fedora or EL release needs a %defattr line in any %files list. The first line of %install is unnecessary as well, since you're obviously not intending to support EL5. This package does not build with the mandatory set of compiler flags. You'll need to make it do so or include some justification for not doing so. Finally, the package fails to build for me in mock on rawhide. No idea what that's about: env XFORM_PRECOMP=yes ../racketcgc -cqu ../../../racket/gc2/xform.rkt --setup . --cpp "gcc -E -I./.. -I../../../racket/gc2/../include -pthread -DMZ_USES_SHARED_LIB " --keep-lines -o xsrc/precomp.h ../../../racket/gc2/precomp.c mprotect for generate-code page failed; aborting mprotect for generate-code page failed; aborting mprotect for generate-code page failed; aborting mprotect for generate-code page failed; aborting make[4]: Leaving directory `/builddir/build/BUILD/racket-5.2.1/src/build/racket/gc2' make[4]: *** [xsrc/precomp.h] Segmentation fault Here's a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4225863 However, it appears to fail in a different way then my mock build, so it's possible that several things are going wrong. Marking as not building. Please clear the Whiteboard field above if providing a version which builds. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review