https://bugzilla.redhat.com/show_bug.cgi?id=834551 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #4 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4225537 $ rpmlint -i -v * poppler-sharp.noarch: I: checking poppler-sharp.noarch: I: enchant-dictionary-not-found es poppler-sharp.noarch: W: incoherent-version-in-changelog 0.0.2-2 ['0.0.3-1.fc17', '0.0.3-1'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. >That's not right. Rpmlint cannot detect this correctly, because former versions of this package doesn't use the %{dist} macro. But please add your full name to the changelog entry. poppler-sharp.noarch: I: checking-url http://www.github.com/jacintos/poppler-sharp (timeout 10 seconds) poppler-sharp.noarch: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. >Ignorable, it's a Mono package. poppler-sharp.src: I: checking poppler-sharp.src: I: checking-url http://www.github.com/jacintos/poppler-sharp (timeout 10 seconds) poppler-sharp.src:56: W: libdir-macro-in-noarch-package (main package) %{_libdir}/%{name}/%{name}.dll* The %{_libdir} or %{_lib} macro was found in a noarch package in a section that gets included in binary packages. This is most likely an error because these macros are expanded on the build host and their values vary between architectures, probably resulting in a package that does not work properly on all architectures at runtime. Investigate whether the package is really architecture independent or if some other dir/macro should be instead. poppler-sharp.src:60: W: libdir-macro-in-noarch-package devel %{_libdir}/pkgconfig/%{name}.pc The %{_libdir} or %{_lib} macro was found in a noarch package in a section that gets included in binary packages. This is most likely an error because these macros are expanded on the build host and their values vary between architectures, probably resulting in a package that does not work properly on all architectures at runtime. Investigate whether the package is really architecture independent or if some other dir/macro should be instead. >Also ignorable, according to your link to the exception from the guidelines. poppler-sharp.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. >Would be better to use spaces generally. Please fix that to make rpmlint somewhat happier. poppler-sharp.src: I: checking-url http://github.com/downloads/jacintos/poppler-sharp/poppler-sharp-0.0.3.tar.gz (timeout 10 seconds) poppler-sharp-devel.noarch: I: checking poppler-sharp-devel.noarch: I: checking-url http://www.github.com/jacintos/poppler-sharp (timeout 10 seconds) poppler-sharp-devel.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. >No. There's no other documentation than the license declaration itself. It's not your task to write docs. poppler-sharp.spec:51: W: libdir-macro-in-noarch-package (main package) %{_libdir}/%{name}/%{name}.dll* The %{_libdir} or %{_lib} macro was found in a noarch package in a section that gets included in binary packages. This is most likely an error because these macros are expanded on the build host and their values vary between architectures, probably resulting in a package that does not work properly on all architectures at runtime. Investigate whether the package is really architecture independent or if some other dir/macro should be instead. poppler-sharp.spec:54: W: libdir-macro-in-noarch-package devel %{_libdir}/pkgconfig/%{name}.pc The %{_libdir} or %{_lib} macro was found in a noarch package in a section that gets included in binary packages. This is most likely an error because these macros are expanded on the build host and their values vary between architectures, probably resulting in a package that does not work properly on all architectures at runtime. Investigate whether the package is really architecture independent or if some other dir/macro should be instead. >See above. poppler-sharp.spec: I: checking-url http://github.com/downloads/jacintos/poppler-sharp/poppler-sharp-0.0.3.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 8 warnings. After you have fixed the issues (spaces/tabs and your name in changelog) I will do a full review. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review