https://bugzilla.redhat.com/show_bug.cgi?id=827101 --- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Some initial comments: Trayer is a very old tool. But you are packaging a forked version named trayer-srg. That's why your package has to be named so to distinguish it from the trayer package (which doesn't exist in Fedora yet, but doesn't matter in this case). Summary: trayer-srg... Don't mention the package name again in the summary. This is not really useful. It's not needed tp provide an URL to the tarball when using a Git snapshot. Just the tarball name, including the way you've got it (as you already did anyway). Requires: libXmu-devel A *devel package as a runtime requirement...? Normally, such packages are needed to build the package. Either move to BuildRequires or explain why trayer-srg needs it. %defattr(-,root,root,-) You may drop this line from the files section unless you are planning to provide it for EPEL < 6. * Thu May 31 2012 Bryan Bickford <bryan@xxxxxxxxxxxxxxx> 1.1 Add the release number at the end of this line: * Thu May 31 2012 Bryan Bickford <bryan@xxxxxxxxxxxxxxx> 1.1-1 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review