https://bugzilla.redhat.com/show_bug.cgi?id=837668 --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- (In reply to comment #2) > (In reply to comment #1) > > * I will fix script-without-shebang according to > > http://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang > > If I remove the execute mode bit from /usr/bin/doctrine-dbal.php, rpmlint > gives the warning "non-executable-in-bin /usr/bin/doctrine-dbal.php 0644L". > How should this file be handled? The "source" file should include the shebang, which is #!@php_bin@ And the package.xml should include a replacement order <file ... <tasks:replace from="@php_bin@" to="php_bin" type="pear-config" /> </file> This could be done by patching the upstream archive A common usage is to drop the suffix for such command under linux only. You can look at "phpci" which use such solution (and also rename / ignore for .bat which is windows specific) https://github.com/remicollet/php-compat-info/blob/master/scripts/phpci https://github.com/remicollet/php-compat-info/blob/master/package.xml#L583 https://github.com/remicollet/php-compat-info/blob/master/package.xml#L1208 Of course, this should be proposed to upstream > > * incorrect-fsf-address: There is only whitespace and mailing address > > differences. I will work with upstream to get this fixed. Is this a > > blocker until it is fixed upstream? > > http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is > > not clear if this is a blocker or not. This is not a blocker, You must only "report" this upstream. > DoctrineDBAL (actually all Doctrine projects) is changing from LGPL license > to MIT license in future release. So, I think, it's ok to ignore this "temporary" warning. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review