https://bugzilla.redhat.com/show_bug.cgi?id=828544 --- Comment #4 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #3) > Issues: > > [!]: MUST Rpmlint output is silent. > [!]: MUST If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %doc. > See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > > The package does not include the documentation files provided in the source > tarball, especially the license file which is included into it. > Please add the contents of the "docs" directory to the resulting rpm as > documentation files. I am reworking the package to mark /usr/share/megaglest/docs/ as %doc, but it is installed: $ rpm -ql megaglest-data | grep megaglest/docs /usr/share/megaglest/docs /usr/share/megaglest/docs/AUTHORS.data.txt /usr/share/megaglest/docs/CHANGELOG.txt /usr/share/megaglest/docs/COPYRIGHT.data.txt /usr/share/megaglest/docs/README.data-license.txt /usr/share/megaglest/docs/README.txt /usr/share/megaglest/docs/cc-by-sa-3.0-unported.txt /usr/share/megaglest/docs/glest_factions /usr/share/megaglest/docs/glest_factions/advanced_architecture.html /usr/share/megaglest/docs/glest_factions/advanced_magic.html /usr/share/megaglest/docs/glest_factions/aerodrome.html /usr/share/megaglest/docs/glest_factions/air_ballista.html /usr/share/megaglest/docs/glest_factions/airship.html /usr/share/megaglest/docs/glest_factions/ancient_summoning.html /usr/share/megaglest/docs/glest_factions/archer.html /usr/share/megaglest/docs/glest_factions/archmage.html /usr/share/megaglest/docs/glest_factions/archmage_tower.html /usr/share/megaglest/docs/glest_factions/barracks.html /usr/share/megaglest/docs/glest_factions/battle_machine.html /usr/share/megaglest/docs/glest_factions/battlemage.html /usr/share/megaglest/docs/glest_factions/behemoth.html /usr/share/megaglest/docs/glest_factions/blacksmith.html /usr/share/megaglest/docs/glest_factions/blade_weapons.html /usr/share/megaglest/docs/glest_factions/castle.html /usr/share/megaglest/docs/glest_factions/catapult.html /usr/share/megaglest/docs/glest_factions/cow.html /usr/share/megaglest/docs/glest_factions/daemon.html /usr/share/megaglest/docs/glest_factions/defense_tower.html /usr/share/megaglest/docs/glest_factions/dragon.html /usr/share/megaglest/docs/glest_factions/dragon_call.html /usr/share/megaglest/docs/glest_factions/drake_rider.html /usr/share/megaglest/docs/glest_factions/energy_compression.html /usr/share/megaglest/docs/glest_factions/energy_sharpening.html /usr/share/megaglest/docs/glest_factions/energy_source.html /usr/share/megaglest/docs/glest_factions/farm.html /usr/share/megaglest/docs/glest_factions/ghost_armor.html /usr/share/megaglest/docs/glest_factions/golem.html /usr/share/megaglest/docs/glest_factions/guard.html /usr/share/megaglest/docs/glest_factions/hell_gate.html /usr/share/megaglest/docs/glest_factions/horseman.html /usr/share/megaglest/docs/glest_factions/index.html /usr/share/megaglest/docs/glest_factions/initiate.html /usr/share/megaglest/docs/glest_factions/library.html /usr/share/megaglest/docs/glest_factions/mage_tower.html /usr/share/megaglest/docs/glest_factions/mana_compression.html /usr/share/megaglest/docs/glest_factions/ornithopter.html /usr/share/megaglest/docs/glest_factions/piercing_weapons.html /usr/share/megaglest/docs/glest_factions/pig.html /usr/share/megaglest/docs/glest_factions/rider.html /usr/share/megaglest/docs/glest_factions/robotics.html /usr/share/megaglest/docs/glest_factions/shield_level_1.html /usr/share/megaglest/docs/glest_factions/shield_level_2.html /usr/share/megaglest/docs/glest_factions/stables.html /usr/share/megaglest/docs/glest_factions/summoner.html /usr/share/megaglest/docs/glest_factions/summoner_guild.html /usr/share/megaglest/docs/glest_factions/swordman.html /usr/share/megaglest/docs/glest_factions/technician.html /usr/share/megaglest/docs/glest_factions/technodrome.html /usr/share/megaglest/docs/glest_factions/tower_of_souls.html /usr/share/megaglest/docs/glest_factions/training_field.html /usr/share/megaglest/docs/glest_factions/wicker_behemoth.html /usr/share/megaglest/docs/glest_factions/wicker_daemon.html /usr/share/megaglest/docs/glest_factions/worker.html > [!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm > -q > --requires). > > In my opinion megaglest-data should require megaglest, as alone it is quite > ueseless given the fact that there is no other engine able to run the > contents of the game. > I don't know if it's correct or not so I let you decide. I've seen that > megaglest requires megaglest-data, and that is fine. Not sure how to properly do it from a noarch package, but if cleaning up a system, it should be marked as an "orphan" package. > [!]: MUST Sources used to build the package match the upstream source, as > provided in the spec URL. > http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net > > The sourceforge url downloads an html file, according to the packaging > guidelines sourceforge urls' should be explicitly declared as in the > packaging guidelines. Corrected in latest package. > Apart from these issues the package is good for me. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review