https://bugzilla.redhat.com/show_bug.cgi?id=828544 --- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> --- Issues: [!]: MUST Rpmlint output is silent. [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text The package does not include the documentation files provided in the source tarball, especially the license file which is included into it. Please add the contents of the "docs" directory to the resulting rpm as documentation files. [!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). In my opinion megaglest-data should require megaglest, as alone it is quite ueseless given the fact that there is no other engine able to run the contents of the game. I don't know if it's correct or not so I let you decide. I've seen that megaglest requires megaglest-data, and that is fine. [!]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net The sourceforge url downloads an html file, according to the packaging guidelines sourceforge urls' should be explicitly declared as in the packaging guidelines. Apart from these issues the package is good for me. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review