https://bugzilla.redhat.com/show_bug.cgi?id=836362 Matt Spaulding <mspaulding06@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspaulding06@xxxxxxxxx --- Comment #1 from Matt Spaulding <mspaulding06@xxxxxxxxx> --- This is an unofficial practice review. Rpmlint: - Found "wrong-file-end-of-line-encoding" warnings - Found "unexpanded-macro" warnings - Found one "file-not-utf8" warning Considering these ignorable based on: https://bugzilla.redhat.com/show_bug.cgi?id=721057 https://bugzilla.redhat.com/show_bug.cgi?id=786249 Package Review: - package meets package naming guidelines - package meets Ruby guidelines - base package name matches spec name - legible and in American English - license MIT is okay - license file included in %doc section - MD5 sum on tarball matches that of the upstream tarball - no missing BuildRequires - the "ruby" and "ruby(abi)" BuildRequires are not necessary - the "ruby" Requires is not necessary - no locales included - not a relocatable package - owns all directories it creates - no duplicate files in %files section and all file names are valid utf-8 - file timestamps are okay, using "cp -a" - consistent macro use - includes -docs subpackage for documentation - no files in %doc section are executable - no bundled system libraries - no development files - no static libraries - no need for .desktop file - builds on x86 successfully in mock - running example irc bot from examples directory worked - no man pages, though it has ruby documentation files Fixes: - remove "ruby" and "ruby(abi)" BuildRequires - remove "ruby" Requires -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review