https://bugzilla.redhat.com/show_bug.cgi?id=823679 --- Comment #5 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Update, with RHEL 5 legacy stuff removed and license modified to reflect the cmap content. Spec: http://venus.arosser.com/fedora/pdfminer/python-pdfminer.spec SRPM: http://venus.arosser.com/fedora/pdfminer/python-pdfminer-20110515-2.fc17.src.rpm (In reply to comment #4) > Just a note that this code appears to bundle some data from Adobe that is > not under the MIT license. According to cmapsrc/README.txt it appears to be > under the 3-clause BSD license. > > So there are two issues: > > The License: tag is wrong; it needs to be something like "MIT and BSD" and > then indicate which parts of the final package are under which license. > (And looking at the built package that's not immediately clear to me.) > > The bundling may or may not run afoul of the general bundling prohibition: > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries. Since, > again, it's not immediately clear to me what happens to that cmap data, I > can't really say what should happen here. So... it looks like, because I was calling "make cmap" *after* "python setup.py build", the cmap data is not being installed into the package. I've fixed this, and now the cmap data is being stored in: "/usr/lib/python2.7/site-packages/pdfminer/cmap". So this folder would be under the BSD license, then- I've updated the License tag and put a comment there explaining this. I'm not sure about the bundling though. One option would be for me to simply remove it, as it's not a vital component of the package. The maintainer marks it as an optional step for CJK language support here- http://www.unixuser.org/~euske/python/pdfminer/index.html#install. So, if the bundling of the cmap data does violate the bundling prohibition, it can just be removed. > Also, if you do not intend to package this for RHEL5, you can remove > BuildRoot:, the entire %clean section, and the first line of %install. Ah, okay. Yeah, I have no intention of packaging for RHEL5, so I've removed all that. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review