[Bug 837705] Review Request: python26-requests - HTTP library, written in Python, for human beings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=837705

--- Comment #5 from Jon Ciesla <limburgher@xxxxxxxxx> ---
- rpmlint checks return:

Clean, except for zero-length requests/async.py.  Probably ignorable.

- package meets naming guidelines
- package meets packaging guidelines
- license ( ISC and MIT ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Running a mock build to test BR, but I think that's fine, from what I can tell.

Overall very good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]