https://bugzilla.redhat.com/show_bug.cgi?id=731906 --- Comment #5 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Independent of comment 4, some issues: * The src.rpm is from August 2011. It has not been touched since then, and apparently, many months have passed without trying to bring it into shape with the help of the https://fedoraproject.org/wiki/Packaging:ReviewGuidelines * At least the first "MUST" item from the Review Guidelines (which are not just for reviewers, because every packager ought to be familiar with them) should have been processed: | MUST: rpmlint must be run on the source rpm and all binary rpms the build | produces. The output should be posted in the review. It finds a few issues. Hint. ;) > BuildRequires: glibc >= 2.5-12, glibc-devel >= 2.5-12 glibc-devel already requires glibc. With full version-release even. 2.5-12 is the original package from RHEL5, so even for Fedora EPEL 5, specifying >= 2.5-12 is superfluous. > Requires: glibc >= 2.5-12 https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > URL: http://www.crypt.gen.nz/logsurfer/ Hmmm, that's a surprise. :-( Nothing mandates that you would need to push many updates to this ticket, *but* there has been an 1.8 release on Sep 5th 2011, including a fix for a double-free. That would have been a great reason for an update and to demonstrate that you're willing to maintain this package. > umask 022 This is the default, isn't it? > %configure \ > --with-etcdir=%{_sysconfdir} \ > --prefix=%{_prefix} \ > --exec-prefix=%{_exec_prefix} \ > --mandir=%{_mandir} See output of "rpm --eval %configure" to eliminate defaults. > install -m 755 src/logsurfer $RPM_BUILD_ROOT%{_bindir}/ > install -m 644 man/*.1.* $RPM_BUILD_ROOT%{_mandir}/man1/ > install -m 644 man/*.4.* $RPM_BUILD_ROOT%{_mandir}/man4/ > install -m 644 %{SOURCE1} $RPM_BUILD_ROOT%{_sysconfdir}/logsurfer/logsurfer.conf https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps > %config(noreplace) %{_sysconfdir}/logsurfer/logsurfer.conf https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review